Change in ovirt-engine-sdk-ruby[master]: Fix reading of lists of elements
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix reading of lists of elements
......................................................................
Fix reading of lists of elements
Currently the method that read lists of elements doesn't handle
correctly empty elements without close tags. For example, when reading
the following cluster:
<cluster>
...
<required_rng_sources/>
<switch_type>legacy</switch_type>
</cluster>
The 'legacy' value of the 'switch_type' element is interpreted as one of
the values of the previous 'required_rng_sources' list. This patch fixes
the method and introduces two tests to verify that it works correctly.
Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e
Bug-Url: https://bugzilla.redhat.com/1373436
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_xml_reader.c
A sdk/spec/cluster_reader_spec.rb
M sdk/spec/xml_reader_spec.rb
3 files changed, 79 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>