Change in ovirt-engine[master]: core: Consolidated similar validations in add/update storage...
Tal Nisan has submitted this change and it was merged.
Change subject: core: Consolidated similar validations in add/update storage connection
CDA
......................................................................
core: Consolidated similar validations in add/update storage connection CDA
AddStorageServerConnection & UpdateStorageServerConnection command both
contained a lot of similar validations in the CDA part, all those validations
were extracted to the parent class for better readability and easier
maintenance
Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb
Bug-Url: https://bugzilla.redhat.com/1129597
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
3 files changed, 31 insertions(+), 45 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server