Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix console issues
......................................................................
frontend: Fix console issues
This patch fixes
- an NPEx in the console cache refreshing code,
- loading consoles state from local storage on VmConsoles creation to
ensure the initial state corresponds to local storage,
- fixes regression from 04d7c8c37d7ce18f014e505cd5c46e25610d7 that
causes problems with loading UserPortalListModel and
UserPortalBasicListModel items when no pools were present.
Change-Id: I5219b77cd013744bec8a1336bfc578fca3ec4b2b
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
5 files changed, 96 insertions(+), 83 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/23243
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5219b77cd013744bec8a1336bfc578fca3ec4b2b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server