9:17 a.m.
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Added infrastructure for linking to System Tree items
......................................................................
webadmin: Added infrastructure for linking to System Tree items
This will facilitate adding links to tabs and subtabs, which when
pressed will select the corresponding item in the System Tree.
* LinkColumnWithTooltip is used to display text in a CellTable column
as a link, such that upon clicking a supplied FieldUpdater is
triggered.
* SystemTreeModel is modified to enable easy entity lookup by ID. To
enable access to a SystemTreeItemModel, for example to be accessed
by a link, one should add it to the member map treeItemById.
* SystemTreeProviderModel now has a setSelectedItem() method that
receives a GUID, and then looks up the corresponding
SystemTreeItemModel using that GUID and sets that model as selected.
* A convenience method is added to SystemTree to expand the whole path
from the root of the tree to a target node, rather than expanding the
whole tree up to a certain level.
* Small workaround is used to bypass a GWT CellTree issue.
Link to GWT CellTree issue:
http://code.google.com/p/google-web-toolkit/issues/detail?id=6310
Change-Id: I799aa4dfcd8ad7264057810e408cd1c64ea711e8
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/LinkCellWithTooltip.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/LinkColumnWithTooltip.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextColumnWithTooltip.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SystemTreeModelProvider.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java
7 files changed, 157 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15522
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I799aa4dfcd8ad7264057810e408cd1c64ea711e8
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server