Change in ovirt-engine[master]: backend: null checks when calling DiskImageDaoImpl.getAncest...
Tal Nisan has submitted this change and it was merged.
Change subject: backend: null checks when calling DiskImageDaoImpl.getAncestor(id)
......................................................................
backend: null checks when calling DiskImageDaoImpl.getAncestor(id)
Calling to DiskImageDaoImpl.getAncestor(Guid id) never returns null (see
DiskImageDaoTest.testGetAncestorForFather).
Thus, it's useless to check whether its return value is null each time
we call it.
Change-Id: I7f2acc136330c504c20034d9fdc24854546e3801
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
2 files changed, 1 insertion(+), 13 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/47992
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f2acc136330c504c20034d9fdc24854546e3801
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org