Change in ovirt-engine[master]: core: Remove public setter from enum "StorageDomainOvfInfoSt...
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Remove public setter from enum
"StorageDomainOvfInfoStatus"
......................................................................
core: Remove public setter from enum "StorageDomainOvfInfoStatus"
This is needed in order to avoid the following findbugs warning:
Public enum method unconditionally sets its field
This public method declared in public enum unconditionally sets enum
field, thus this field can be changed by malicious code or by accident
from another package. Though mutable enum fields may be used for lazy
initialization, it's a bad practice to expose them to the outer world.
Consider removing this method or declaring it package-private.
Bug kind and pattern: ME - ME_ENUM_FIELD_SETTER
Change-Id: I1caf9f40d215fea937cb7deee412563e562b486b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainOvfInfoStatus.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46582
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1caf9f40d215fea937cb7deee412563e562b486b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org