Change in ovirt-engine[master]: webadmin: Create new VM | Not all selected nics are created ...
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Create new VM | Not all selected nics are created on the VM
......................................................................
webadmin: Create new VM | Not all selected nics are created on the VM
Opening and closing ghost profile instance type editor without selecting a
value causes the first acceptable value to be displayed at the header text
box (just to be displayed, not really be selected-> the real value is
still null).
It is caused because ListModelTypeAheadListBox->adjustSelectedValue()
calls in the described case-
'setValue(acceptableValues.iterator().next())' without firing valueChange
event. The displayed value is changed, but the model.selectedValue is
still null.
Calling setValue with 'true' for 'fireValueChangeEvent' fixes the issue.
But, as I understand, if the the selected value ('getValue()') was 'null'
and wasn't changed manually to another value.
There is no reason to override it here by the first item in the list.
Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791
Bug-Url: https://bugzilla.redhat.com/1115788
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
1 file changed, 13 insertions(+), 14 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Alona Kaplan: Verified
Lior Vernia: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30490
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server