Change in ovirt-engine[master]: core: CDA msg when removing a template's disk without specif...
Liron Aravot has submitted this change and it was merged.
Change subject: core: CDA msg when removing a template's disk without specifing
domain.
......................................................................
core: CDA msg when removing a template's disk without specifing domain.
Deleting a template's disk must be performed with the disk's storage
domain, as deleting a template's disk is enabled only if this disk has
copies on other domains.
Hence, a storage domain must be provided when calling RemoveDiskCommand
with a template's disk.
This patch adds that condition into RemoveDiskCommand's CDA with a
proper message.
Bug-Url: https://bugzilla.redhat.com/1229212
Change-Id: Id5f0c1bda25b5fbadbf153bfcb84c78950216e66
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 25 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Amit Aviram: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Liron Aravot: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5f0c1bda25b5fbadbf153bfcb84c78950216e66
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org