Change in ovirt-engine[master]: engine: AssignQuota button under disks refresh bug
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: AssignQuota button under disks refresh bug
......................................................................
engine: AssignQuota button under disks refresh bug
In case a quota mode set to !Disabled (or vice-versa) the
Assign Quota button (in various disk tabs) availability wasn't refreshed.
The problem caused because we relied on the selected DC tree
item quota mode, which not getting refreshed in current ui infrastructure.
Instead we will fetch quota mode from disk BE itself.
A bug was fixed in DB to reference data center even
if there is no quota for the disk (using the storageDomain DC instead
of quota table).
To allow new functionality for all tabs, introduced a new interface
and static public utility method to avoid code duplication.
Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c
Bug-Url: https://bugzilla.redhat.com/950519
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
5 files changed, 100 insertions(+), 67 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>