Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Don't call finazlize on image upload progress.
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Don't call finazlize on image upload progress.
......................................................................
webadmin: Don't call finazlize on image upload progress.
Currently, when a progress callback triggered while uploading an image,
and the upload status is not "TRANSFERRING", there is a call to finalize
upload. This is wrong, because in any scenario in which the status
becomes anything other than "TRANSFERRING", finalizing the upload
already happens. that means that currently a call for finalizing will
happen twice.
Remove the call for finalizeUpload in onProgress().
Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313
Bug-Url: https://bugzilla.redhat.com/1343878
Bug-Url: https://bugzilla.redhat.com/1328877
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/62413
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>