Change in ovirt-engine[ovirt-engine-4.0.4]: webadmin: infinite loop in new VM/pool dialog
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: infinite loop in new VM/pool dialog
......................................................................
webadmin: infinite loop in new VM/pool dialog
Open new VM/pool dialog and pick a template which had non-null custom
compatibility version, the dialog ends up in infinite refresh loop.
The reason was that the CoreVmBaseToUnitBuilder.postBuild called the
model.getCustomCompatibilityVersion().setSelectedItem(vm.getCustomCompatibilityVersion());
all the time regardless of the fact it changed or not. This change leads to a
full refresh of the whole dialog, including this builder.
Fixed by setting this value only if changed.
Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922
Bug-Url: https://bugzilla.redhat.com/1373204
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
(cherry picked from commit a453c83060eba01a630ab7fcdff5645e168ceed8)
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>