Change in ovirt-engine[master]: engine: Completed task still shown as 'running' in UI
Ori Liel has submitted this change and it was merged.
Change subject: engine: Completed task still shown as 'running' in UI
......................................................................
engine: Completed task still shown as 'running' in UI
Currently when SPM host goes down due to connectivity issue,
VdsNotRespondingTreatment command is left forever 'running'
(hourglass icon) in the WebAdmin tasks pane.
This happens becuase when SPM host goes down the datacenter
should go down, and thus an internal command:
SetStoragePoolStatus is invoked, and there is a mixup in
the Execution-Context.
This patch solves this bug locally, although a similar
issue may exist in other places and handling of
CommandContext and ExecutionContext should be revisited.
Bug-Url: https://bugzilla.redhat.com/1145099
Change-Id: I4f5fbaef3e8c57fbad7997cb67282a6c163b6b03
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionContext.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/FenceValidator.java
3 files changed, 47 insertions(+), 26 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved; Passed CI tests
Martin Peřina: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44136
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f5fbaef3e8c57fbad7997cb67282a6c163b6b03
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org