Change in ovirt-engine[master]: core: RunVm - do not pass compensation context
Liron Aravot has submitted this change and it was merged.
Change subject: core: RunVm - do not pass compensation context
......................................................................
core: RunVm - do not pass compensation context
When running stateless vm, the RunVm command first creates a snapshot for the vm.
When running the create snapshot command, the command context is passed to the child
command - which means that the command compensation context is passed as well.
The compensation in use is NoOp compensation context it causes the
executed child command to use that compensation context as well, on case
of failure the db changes won't be reverted which will leave us with
inconsistent db state.
Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122
Bug-Url: https://bugzilla.redhat.com/1334105
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>