Change in ovirt-engine[master]: core: RemoveSnapshotCommand: move image validation
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveSnapshotCommand: move image validation
......................................................................
core: RemoveSnapshotCommand: move image validation
RemoveSnapshotCommand's canDoAction performs several validations only if
the VM has images, and several regardless.
Since ImagesHandler.PerformImagesChecks originally also validated VM
states, it was called regardless of whether the VM has images or not.
Since this is no longer the case, it can now be moved to its rightful
place.
Change-Id: I5e491f97134c3017fd53bfc159cf47f83ba74ae7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java
2 files changed, 9 insertions(+), 7 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e491f97134c3017fd53bfc159cf47f83ba74ae7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>