Change in ovirt-engine[master]: engine: Remove StorageType.ALL value
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Remove StorageType.ALL value
......................................................................
engine: Remove StorageType.ALL value
This value is used only by GetVGListVDSCommand, but the fact we are
talking about VGs implies that this is a block storage - ISCSI or FCP
so in case we can't determine its exact type the UNKNOWN option is
probably more suitable than ALL.
Change-Id: I761d322f88304353bb11fceeed39305dd6698045
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
M
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java
A packaging/dbscripts/upgrade/03_04_0210_replace_storage_type_all_with_unknown.sql
4 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21315
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I761d322f88304353bb11fceeed39305dd6698045
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server