From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. (
https://gerrit.ovirt.org/79193
)
Change subject: core: skip memory disks in engine xml
......................................................................
core: skip memory disks in engine xml
The disks that hold the memory dump and metadata have no corresponding
devices (since they are not really devices of the VM) and that lead to
NPE while generating the engine XML. In face, these disks should not
be consdered while generating the engine XML since they have no
representation in libvirt's domain XML. Therefore, memory disks are
now ignored while generating the engine XML.
Change-Id: I2d1f92d3317bb1346cb66f5dfe24f1596071624a
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/79193
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d1f92d3317bb1346cb66f5dfe24f1596071624a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>