Tal Nisan has submitted this change and it was merged.
Change subject: core: Change VmDevice plugged property to a primitive boolean
......................................................................
core: Change VmDevice plugged property to a primitive boolean
Since VmDevice.getIsPlugged always returns a value of true/false we can
change all legacy null values in the DB to false and return them as is
without the redundant check.
Change-Id: I53064843f448d4ef75baed0d5811e207080257fc
Bug-Url:
https://bugzilla.redhat.com/1352966
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java
A
packaging/dbscripts/upgrade/04_00_0790_change_vm_device_null_plugged_values_to_false.sql
4 files changed, 15 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/60360
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53064843f448d4ef75baed0d5811e207080257fc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>