Barak Azulay has submitted this change and it was merged. Change subject: Updated spec file to follow packaging guide lines (BZ#772608) ...................................................................... Updated spec file to follow packaging guide lines (BZ#772608) * Bumped the ovirt-guest-agent version in configure.ac to 1.0.6 as preparation for the next release * Updated INSTALL to the current version * autogen.sh is now using autoreconf -ivf * Added m4 folder Changes to spec file: - Introduced ovirt-guest-agent-service noarch package which provides ovirt-guest-agent and avoids duplication of the same package content - Fixed various rpmlint errors and warnings - Added required build requires - Removed unnecessary build requires - Removed unnecessary call to autoreconf in setup section - Marked config files as such - Excluded unwanted files instead of deleting them - Moved folder creation and symlink creation from spec to autotools - License file change reflected - Removed systemd unit file installation - Removed creation of log and lock folders Changes to build system: - Added creation of /usr/share/ovirt-guest-agent - Added creation of symlinks for: - ovirt-hibernate - ovirt-shutdown - ovirt-locksession - Systemd unit files are now installed, if systemd is detected - Log and lock folders for ovirt-guest-agent are now created on install - Added missing -fPIC for the pam module - Various improvements to configure.ac and several Makefile.am files in regards of installation directory detection and installation handling Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=772608 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt; --- M INSTALL M Makefile.am M autogen.sh M configure.ac M gdm-plugin/Makefile.am M kdm-plugin/Makefile.am A m4/.keep M ovirt-guest-agent.spec M ovirt-guest-agent/Makefile.am M pam-ovirt-cred/Makefile.am 10 files changed, 164 insertions(+), 111 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd Gerrit-PatchSet: 19 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt; Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt; Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com&gt; Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt; Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com&gt; Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;