Oved Ourfali has submitted this change and it was merged. Change subject: core: Refactor FenceProxyLocator ...................................................................... core: Refactor FenceProxyLocator 1. Makes FenceProxyLocator more readable 2. Fixes bug when testing agents compatibility between proxy candidate and fenced host 3. Makes FenceProxyLocatorTest more readable 4. Adds more tests to FenceProxyLocatorTest Change-Id: I59d5b46273dbaeb2d73142f1256000e36a6cbdd8 Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java 2 files changed, 376 insertions(+), 254 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59d5b46273dbaeb2d73142f1256000e36a6cbdd8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server