Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Set default vNIC type according to OsInfo
......................................................................
webadmin: Set default vNIC type according to OsInfo
Only set the vNIC type to VirtIO by default if it exists in the OsInfo
vNIC types; if not, pick the first one among the existing values. This
had to be changed for both the vNIC dialog and the VM dialog (where
the vNIC type can't be edited by the user but it is implicitly set
when adding a new vNIC).
Change-Id: I4f09986e661d820b3c10301fa35c840fd9cfe0d8
Bug-Url:
https://bugzilla.redhat.com/996044
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java
5 files changed, 35 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit
http://gerrit.ovirt.org/26925
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f09986e661d820b3c10301fa35c840fd9cfe0d8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server