Tal Nisan has submitted this change and it was merged.
Change subject: core: Renamed the getStorageDomainId Method
......................................................................
core: Renamed the getStorageDomainId Method
The method's name implies that it's a simple getter, even though it does
not always return the expected storage domain even if it exists
(permissions issues for example).
Thus, renamed to getStorageDomainIdForQuery.
Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b
Related-To:
https://bugzilla.redhat.com/1085398
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit
http://gerrit.ovirt.org/34863
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server