Omer Frenkel has submitted this change and it was merged. Change subject: core: [cleanup] extract building parameters code from execute methods ...................................................................... core: [cleanup] extract building parameters code from execute methods Extract the sections that build parameters for internal commands from the execute methods of CreateAllSnapshotsFromVmCommand, RemoveAllVmImagesCommand and RemoveDiskCommand. that way, the execute methods are shorter and more readable. Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 3 files changed, 42 insertions(+), 35 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt;