Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/79016 ) Change subject: backend: DAD initialization in AddExistingBlockStorageDomain ...................................................................... backend: DAD initialization in AddExistingBlockStorageDomain AddExistingBlockStorageDomain deals with block domains, and thus should have its own validation and default value for DAD, similar to AddSANStorageDomain (and not inherit file domains implementation from AddStorageDomainCommon). Since the AddStorageDomainCommand hierarchy is not structured by the storage type, this patch adds a default implementation for validateDiscardAfterDeleteLegal in AddStorageDomainCommand and overrides it in commands that handles block domains. Change-Id: I8e506a92c0534118805de6c9c7adbaa8df5eb9b1 Bug-Url: https://bugzilla.redhat.com/1467781 Signed-off-by: Idan Shaby <ishaby(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommon.java 4 files changed, 28 insertions(+), 31 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/79016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e506a92c0534118805de6c9c7adbaa8df5eb9b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;