Eli Mesika has submitted this change and it was merged.
Change subject: core:we are fencing a host when putting it in...
......................................................................
core:we are fencing a host when putting it in...
we are fencing a host when putting it in maintenance after failed reinstall.
There are two commands that handle Host Maintenance
1) MaintenanceVdsCommand
2) MaintenanceNumberOfVdssCommand
In 1) there is handling in canDoAction that prevents the operation for
InstalledFailed status while this handling is omitted from 2)
I would expect that 2) will contain all validation checks done by 1) and
the best will be that they will call the same validation code. but this
is not the case right now.
To keep my change minimal and risk-less, I will have to copy the
relevant validation block from 1) code to 2)
Change-Id: I1ed67cb14b31597d147cee3a64056e3486f51d26
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=906389
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
1 file changed, 40 insertions(+), 30 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/13746
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ed67cb14b31597d147cee3a64056e3486f51d26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>