Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing canDoAction of DeactiveStorageDomainCommand
......................................................................
core: Fixing canDoAction of DeactiveStorageDomainCommand
With this fix - tasks are associated with their entities, there is no need to query
VDSM for HSM task statuses.
This both saves network communication, and in addition, the VDSM call does not provide
any information on the storage domain, so using it allows only to check if the data
center has running tasks.
With the fix, a query to db to check if the storage domain is associated with
tasks replaces the described above VDSM call.
Change-Id: Ic5841d558a7a5267a67cc9547bac187f9773b87b
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 10 insertions(+), 23 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/6058
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5841d558a7a5267a67cc9547bac187f9773b87b
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>