Tal Nisan has submitted this change and it was merged. Change subject: engine: don't iterate map with keyset in LinkHelper ...................................................................... engine: don't iterate map with keyset in LinkHelper Iterate map with entryset for more efficient iteration. Solves findbug warning of type WMI_WRONG_MAP_ITERATOR Change-Id: I62da8696f89f111b6a3872f02ec8a6dd1663fc34 Signed-off-by: Alissa Bonas <abonas(a)redhat.com&gt; --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62da8696f89f111b6a3872f02ec8a6dd1663fc34 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com&gt; Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server