Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove ChangeFloppy functionality ...................................................................... core: Remove ChangeFloppy functionality The ChangeFloppy functionality is not used anywhere in the code, and could (should) therefore be removed to make the codebase easier to maintain. This claim is confirmed by the fact the ChangeFloppyCommand's constructor calls getVm(), which, in turn calls VmDao. Commit f0dc3d (merged on 25/10/2016) introduced injection for this Dao in AuditLoggableBase, meaning that the DAO would not yet be initialized in the constructor, and calling it would fail with a NullPointerException, making this command unusable. This patch removes the following: 1. The ChangeFloppyCommand and its corresponding enum constant in VdcActionType. 2. The ChangeFloppyVDSCommand it calls, its corresponding enum constant in VDSCommandType, the IVdsServer method it calls and its implementation in JsonRpcVdsServer. 3. AuditLog constants and messages only used by this command. Change-Id: I2ef2972e120a357bd13511b502ce0db8b35711fe Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeFloppyVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java 8 files changed, 0 insertions(+), 78 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ef2972e120a357bd13511b502ce0db8b35711fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com&gt; Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;