Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix group population ...................................................................... aaa: Fix group population The following patch fixes group population for users and groups - a. It does not use DbFacade to get the external id - external id should be retrieved from the directory b. It runs the group population in all cases user information is populated c. At group population - the recrusion is fixed/changed - the LdapGroup object that is created is at ProceedGroupSearchResult , before making the recursive calls at populateGroup. Topic: AAA Change-Id: I599fca005b27f6873cda3e5a46081de3357089b2 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchUserByQueryCommand.java 3 files changed, 29 insertions(+), 30 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I599fca005b27f6873cda3e5a46081de3357089b2 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server