Oved Ourfali has submitted this change and it was merged. Change subject: backend: bugfix in VdsManager on failedToRunVm ...................................................................... backend: bugfix in VdsManager on failedToRunVm Bug description: onVdsDuringFailureTimer assumes that number of attempts is always >= 0 but this assumption is not always true. The reason for this is that pausing a quartz job does not insure it will not run anymore but simply pauses the trigger, so previously scheduled jobs might still run. This is resolved  by using simpler one time scheduling. This patch introduces a behavioral change: Previously onVdsDuringFailureTimer would reduce failed attempt by 1 (which is problamatic since it no longer represents failed attempts when it is decremented by 1 every x time). Previously there would be a competition between onVdsDuringFailureTimer calls to failedToRunVm calls. Now whenever attempt limit is reached number of attempts is set to 0. The effect of this is if we have a host failing to run vms and those vms were able to run on other hosts and we detect no oter problem on in (its status is up) it will keep trying to recover every 30 min (default) regardless. New behavior is consistent and easy to understand. Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066693 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com&gt; --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 15 insertions(+), 23 deletions(-) Approvals: mooli tayer: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server