Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove name query parameters containers ...................................................................... engine: Remove name query parameters containers This patch removes all the query parameter classes that are nothing more than containers for an entity name and replaces all their usages with NameQueryParameters. Change-Id: Ie17feb6bb06323b090dafeefa00ea96c4cc4d5a4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRoleByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagByTagNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVmPoolWithSameNameExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVmTemlateWithSameNameExistQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVmWithSameNameExistQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMNameQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateNameQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/IsVmWithSameNameExistQueryTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAuditLogsByVMNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAuditLogsByVMTemplateNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagNameParametersBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsByNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsGroupByNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmPoolWithSameNameExistsParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmTemlateWithSameNameExistParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmWithSameNameExistParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationByRoleNameParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NameQueryParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateEventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmEventListModel.java 34 files changed, 92 insertions(+), 259 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie17feb6bb06323b090dafeefa00ea96c4cc4d5a4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com&gt; Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server