Allon Mureinik has submitted this change and it was merged. Change subject: core: ScanStorageForUnregistedDisksCommandTest unused code ...................................................................... core: ScanStorageForUnregistedDisksCommandTest unused code generateQueryReturnValueForGetDiskImages was only ever called with succeeded=true, making this argument useless. Inlining it then revealed several code paths that were never used, so they could safely be removed. Change-Id: Ic411891e3c9c98af69c55dc33687529f8c19a5b4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommandTest.java 1 file changed, 3 insertions(+), 32 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/70250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic411891e3c9c98af69c55dc33687529f8c19a5b4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;