Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Improved boot protocol behavior in host network dialog
......................................................................
webadmin: Improved boot protocol behavior in host network dialog
It used to be that if the address/subnet/gateway fields were edited,
they would be committed to the VdsNetworkInterface upon pressing OK
even if the chosen boot protocol was for example NONE, in which case
it would be expected that these fields wouldn't be committed. So now
changes are committed only if the chosen boot protocol is IP_STATIC.
Change-Id: I76f3f8d5c3f214927761effa571ca23f2e6c239c
Bug-Url:
https://bugzilla.redhat.com/989360
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 10 insertions(+), 6 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/20346
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76f3f8d5c3f214927761effa571ca23f2e6c239c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server