Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: fixing RunningCommands type
......................................................................
packaging: setup: fixing RunningCommands type
Further code expects a list of running task or command or compesation.
If command table doesn't exist on the system we are going to upgrade
we were passing a Null value that was going to break other code.
Returning an empty list to make it more consistent.
Change-Id: I5b8f03ce655d1a9f450dd79b438a1ef9540f7b29
Bug-Url:
https://bugzilla.redhat.com/1197616
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/39663
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b8f03ce655d1a9f450dd79b438a1ef9540f7b29
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server