Itamar Heim has submitted this change and it was merged. Change subject: core: AddDiskCommand - added disk can never be a disk snapshot ...................................................................... core: AddDiskCommand - added disk can never be a disk snapshot When adding a disk the added disk can never be a disk snapshot, Currently when adding DiskImages the disk's Image object is "active" member has a default value of false, which leads to wrongly treat that disk as a disk snapshot through validations rather than a regular added disk. Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066834 Signed-off-by: Liron Aravot <laravot(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/24715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt; Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server