Allon Mureinik has submitted this change and it was merged. Change subject: core: fix Coverity warnings ...................................................................... core: fix Coverity warnings The patch fixes the following warnings : ** CID 1311515: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java: 473 in org.ovirt.engine.core.bll.RemoveSnapshotSingleDiskLiveCommand.handleAnyChildSPMTaskCompletion(boolean)() ________________________________________________________________________________________________________ *** CID 1311515: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java: 473 in org.ovirt.engine.core.bll.RemoveSnapshotSingleDiskLiveCommand.handleAnyChildSPMTaskCompletion(boolean)() 467 command.getParameters().setTaskGroupSuccess(false); 468 } 469 Backend.getInstance().endAction(VdcActionType.DestroyImage, 470 command.getParameters(), 471 cloneContextAndDetachFromParent()); 472 if (succeeded) { 473 CommandCoordinatorUtil.getCommandEntity(currentChildId).setCallbackNotified(true); 474 } 475 } 476 } 477 } 478 ** CID 1311514: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java: 131 in org.ovirt.engine.core.bll.MergeExtendCommand.handleAnyChildSPMTaskCompletion(boolean)() ________________________________________________________________________________________________________ *** CID 1311514: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java: 131 in org.ovirt.engine.core.bll.MergeExtendCommand.handleAnyChildSPMTaskCompletion(boolean)() 125 command.getParameters().setTaskGroupSuccess(false); 126 } 127 Backend.getInstance().endAction(VdcActionType.ExtendImageSize, 128 command.getParameters(), 129 cloneContextAndDetachFromParent()); 130 if (succeeded) { 131 CommandCoordinatorUtil.getCommandEntity(currentChildId).setCallbackNotified(true); 132 } 133 } 134 } 135 } 136 Change-Id: I2b570ebb029d82e9497b7c06f465b4012dec1ec0 Signed-off-by: emesika <emesika(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b570ebb029d82e9497b7c06f465b4012dec1ec0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org