Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Parameterize Event and IEventListener
......................................................................
webadmin: Parameterize Event and IEventListener
This to further promote type-safety and not have to unsafely-cast
specific event arguments. Also took the chance to parameterize an
event in ReportsListModel (it wouldn't compile off the bat, and I
preferred to parameterize properly than add a cast).
Change-Id: I1ad96ebbc2a4d2baff514d53dba8a222a08d1306
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IEventListener.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java
4 files changed, 24 insertions(+), 23 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit
http://gerrit.ovirt.org/31194
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ad96ebbc2a4d2baff514d53dba8a222a08d1306
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server