Maor Lipchuk has submitted this change and it was merged. Change subject: core: imageupload: don't succeed if session can't be stopped. ...................................................................... core: imageupload: don't succeed if session can't be stopped. Currently, an image uploading session succeeds regardless of succeeding to actually stop the transfer session. This can cause having a disk ready to be used by a VM, which is still open for external I/O to be written into it. This patch verifies that stopping the session succeeds before proceeding to mark the image "Legal", therefor ready to be used. Change-Id: I325c47f575a9fbc40a9653a7ab2178f45086ff41 Signed-off-by: Amit Aviram <aaviram(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 18 insertions(+), 14 deletions(-) Approvals: Amit Aviram: Verified Maor Lipchuk: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I325c47f575a9fbc40a9653a7ab2178f45086ff41 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com&gt; Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;