Roy Golan has submitted this change and it was merged. Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum ...................................................................... engine: Refactor LdapProviderType and LdapVendorNameEnum This patch is still a work in progress. Its not complete and there are holes in it. Like when merging LdapProviderType and LdapVendorNameEnum I did not see a Vendor Name with AD. Need to know what goes there. Also need to know what to do with 'general'. I am emailing it out early to get feedback. There will be more versions of it out based on feedback. Roy and Yair, Is this what you were thinking? Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/Domain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPILdapTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSETask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapProviderType.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapVendorNameEnum.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RootDSEFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SimpleLdapTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTester.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapVendorNameEnum.java 18 files changed, 35 insertions(+), 49 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt; Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;