From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Remove PairFirstComparator
......................................................................
engine: Remove PairFirstComparator
PairFirstComparator was a convenience class introduced before the
engine used Java 8. Now that it does (including in the frontend),
there's no advantage in using new
PairFirstComparator<>(someComparator) over Java's built in mechanism
of Comparator.comparing(Pair::getFirst, someComparator).
This patch removes this now-redundant class and uses Java's built-in
mechanisms instead.
Change-Id: Ic7409a72d09821df907af207563f8eabc5953504
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairFirstComparator.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
D
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/PairFirstComparatorTest.java
M
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java
7 files changed, 6 insertions(+), 62 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/76488
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7409a72d09821df907af207563f8eabc5953504
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>