Mike Kolesnik has submitted this change and it was merged.
Change subject: core: few fixes in MacAddressRangeUtils.java
......................................................................
core: few fixes in MacAddressRangeUtils.java
* encapsulated check whether multicast bit is set.
* fixed use of stopAfter which stopped one iteration later than it should
* encapsulated parsing MAC from string to long -- fixed exception handling
* added methods for reverse trasnformation: long to string
Change-Id: I098ade5fc3854ad23236abceebb87cc51908c65f
Bug-Url:
https://bugzilla.redhat.com/1063064
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java
2 files changed, 62 insertions(+), 21 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/26404
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I098ade5fc3854ad23236abceebb87cc51908c65f
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server