From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Include jcl-over-slf4j into tools modules
......................................................................
core: Include jcl-over-slf4j into tools modules
Apache commons-logging libraries are reimplemented within WildFly.
In older versions the reimplementation has been provided by
'org.slf4j.jcl-over-slf4j' module, but in newer version
reimplementation has been changed to
'org.jboss.logmanager.commons.logging'.
This works fine if application is executed inside running WildFly,
but we are using those libraries also outside running EAP in command
line tools. In order to be able to use slf4j as our logging frontend
we are using standard slf4j implementation instead of WildFly
reimplementation of slf4j for our command line tools. Apache
commons-logging is used indirectly through commons-configuration also
in command line tool engine-config, so we would need to add
'org.slf4j.jcl-over-slf4j' into our special modules for command
line tools to override this reimplementation change.
Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215
Bug-Url:
https://bugzilla.redhat.com/1457900
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/dependencies/tools/pom.xml
A
backend/manager/dependencies/tools/src/main/modules/org/apache/commons/logging/main/module.xml
A
backend/manager/dependencies/tools/src/main/modules/org/slf4j/jcl-over-slf4j/main/module.xml
M ovirt-engine.spec.in
4 files changed, 50 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Martin Peřina: Verified
Juan Hernandez: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/77863
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.2.z
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>