Allon Mureinik has submitted this change and it was merged. Change subject: core: MemoryStorageHandlerTest comparators ...................................................................... core: MemoryStorageHandlerTest comparators BiggestStorageDomainComparator and SmallestStorageDomainComparator are dummy comparator that place a given StorageDomain at the end or beginning of a list, respectively, and are used to test the MemoryStorageHandler's mechanism. This patch replaces those boiler-plate implementations with with simple oneliners that have the same functionality, and are arguably easier to read. Change-Id: Ie43b64f4bb119a2a1a84132294ddb9258970569d Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java 1 file changed, 3 insertions(+), 64 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie43b64f4bb119a2a1a84132294ddb9258970569d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;