From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. (
https://gerrit.ovirt.org/78908 )
Change subject: core: Refine live merge validation
......................................................................
core: Refine live merge validation
Currently, there is a validation that disable running concurrent live
merge even for snapshots that created on different disks. In this patch,
validation is refined to disable executing concurrent live merge
operations only if the snapshots contain same disk(s).
Note that this new validation is only used for live merge. There are
other operations (add Vm from snapshot, create Vm template, migrate Vm
and remove Vm) that will still use the previous validation. In case we
decide we want to refine the validation for those operations, this will
be done in separate patches.
Change-Id: I984b4ccf10993e982363e8b35871e97fed57e56e
Bug-Url:
https://bugzilla.redhat.com/1465539
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java
3 files changed, 63 insertions(+), 3 deletions(-)
Approvals:
Benny Zlotnik: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit
https://gerrit.ovirt.org/78908
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I984b4ccf10993e982363e8b35871e97fed57e56e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>