Moti Asayag has submitted this change and it was merged. Change subject: core: Prevent NPE with cobertura ...................................................................... core: Prevent NPE with cobertura The NetworkDaoDbFacadeImpl contains an abstract row mapper and then two derived ones, and all of them, including the abstract one contain a singleton. The singleton in the abstract one is never used, and it causes a NPE if used. Some tools, like cobertura, generate code that uses all the fields, and thus reveal this hidden NPE. This patch just removes the unused field. Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com&gt; --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server