Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use Enums in the Model ...................................................................... restapi: Use Enums in the Model This patch inserts references to the correct enums where appropriate in the model instead of strings. Change-Id: I1673f75793f6ba66e8b92eb7cb6eb2e1f9cc4740 Signed-off-by: Ori Liel <oliel(a)redhat.com&gt; --- M backend/manager/modules/restapi/README.md D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/AccessProtocol.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/Architecture.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/AutoNumaStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/BootDevice.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/BootProtocol.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ConfigurationType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/CpuMode.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/CreationStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DataCenterStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DiskInterface.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DiskStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DiskStorageType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DisplayType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/EntityExternalStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ExternalSystemType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/FenceType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/FileType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GlusterState.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GlusterVolumeType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GraphicsType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HookContentType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HookStage.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HookStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HostProtocol.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HostStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/InheritableBoolean.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/KdumpStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/LogSeverity.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/LunStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/MessageBrokerType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/MigrateOnError.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NetworkPluginType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NetworkStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NfsVersion.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NicInterface.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NicStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NumaTuneMode.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OpenstackVolumeAuthenticationKeyUsageType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PayloadEncoding.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PmProxyType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PolicyUnitType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PowerManagementStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QosType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QuotaModeType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ReportedDeviceType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ResolutionType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/RngSource.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/RoleType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SELinuxMode.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ScsiGenericIO.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SerialNumberPolicy.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SnapshotStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SnapshotType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SpmState.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SsoMethod.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageDomainStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageDomainType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageFormat.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/TemplateStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/TransportType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/UsbType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmAffinity.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmDeviceType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmPoolType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmStatus.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmType.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VnicPassThroughMode.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/WatchdogAction.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/WatchdogModel.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/EnumGenerator.java A backend/manager/modules/restapi/model/src/main/java/types/AccessProtocol.java M backend/manager/modules/restapi/model/src/main/java/types/AgentConfiguration.java A backend/manager/modules/restapi/model/src/main/java/types/Architecture.java A backend/manager/modules/restapi/model/src/main/java/types/AutoNumaStatus.java M backend/manager/modules/restapi/model/src/main/java/types/Boot.java A backend/manager/modules/restapi/model/src/main/java/types/BootDevice.java A backend/manager/modules/restapi/model/src/main/java/types/BootProtocol.java M backend/manager/modules/restapi/model/src/main/java/types/Cluster.java M backend/manager/modules/restapi/model/src/main/java/types/Configuration.java A backend/manager/modules/restapi/model/src/main/java/types/ConfigurationType.java M backend/manager/modules/restapi/model/src/main/java/types/Cpu.java A backend/manager/modules/restapi/model/src/main/java/types/CpuMode.java A backend/manager/modules/restapi/model/src/main/java/types/CreationStatus.java M backend/manager/modules/restapi/model/src/main/java/types/DataCenter.java A backend/manager/modules/restapi/model/src/main/java/types/DataCenterStatus.java M backend/manager/modules/restapi/model/src/main/java/types/Disk.java A backend/manager/modules/restapi/model/src/main/java/types/DiskInterface.java A backend/manager/modules/restapi/model/src/main/java/types/DiskStatus.java A backend/manager/modules/restapi/model/src/main/java/types/DiskStorageType.java M backend/manager/modules/restapi/model/src/main/java/types/Display.java A backend/manager/modules/restapi/model/src/main/java/types/DisplayType.java A backend/manager/modules/restapi/model/src/main/java/types/EntityExternalStatus.java M backend/manager/modules/restapi/model/src/main/java/types/ErrorHandling.java M backend/manager/modules/restapi/model/src/main/java/types/Event.java A backend/manager/modules/restapi/model/src/main/java/types/ExternalSystemType.java A backend/manager/modules/restapi/model/src/main/java/types/FenceType.java M backend/manager/modules/restapi/model/src/main/java/types/GlusterHook.java M backend/manager/modules/restapi/model/src/main/java/types/GlusterServerHook.java A backend/manager/modules/restapi/model/src/main/java/types/GlusterState.java M backend/manager/modules/restapi/model/src/main/java/types/GlusterVolume.java A backend/manager/modules/restapi/model/src/main/java/types/GlusterVolumeType.java M backend/manager/modules/restapi/model/src/main/java/types/GraphicsConsole.java A backend/manager/modules/restapi/model/src/main/java/types/GraphicsType.java A backend/manager/modules/restapi/model/src/main/java/types/HookContentType.java A backend/manager/modules/restapi/model/src/main/java/types/HookStage.java A backend/manager/modules/restapi/model/src/main/java/types/HookStatus.java M backend/manager/modules/restapi/model/src/main/java/types/Host.java M backend/manager/modules/restapi/model/src/main/java/types/HostNic.java A backend/manager/modules/restapi/model/src/main/java/types/HostProtocol.java A backend/manager/modules/restapi/model/src/main/java/types/HostStatus.java M backend/manager/modules/restapi/model/src/main/java/types/HostStorage.java A backend/manager/modules/restapi/model/src/main/java/types/InheritableBoolean.java A backend/manager/modules/restapi/model/src/main/java/types/KdumpStatus.java A backend/manager/modules/restapi/model/src/main/java/types/LogSeverity.java M backend/manager/modules/restapi/model/src/main/java/types/LogicalUnit.java A backend/manager/modules/restapi/model/src/main/java/types/LunStatus.java A backend/manager/modules/restapi/model/src/main/java/types/MessageBrokerType.java M backend/manager/modules/restapi/model/src/main/java/types/Method.java A backend/manager/modules/restapi/model/src/main/java/types/MigrateOnError.java M backend/manager/modules/restapi/model/src/main/java/types/MigrationOptions.java A backend/manager/modules/restapi/model/src/main/java/types/NetworkPluginType.java A backend/manager/modules/restapi/model/src/main/java/types/NetworkStatus.java A backend/manager/modules/restapi/model/src/main/java/types/NfsVersion.java M backend/manager/modules/restapi/model/src/main/java/types/Nic.java M backend/manager/modules/restapi/model/src/main/java/types/NicConfiguration.java A backend/manager/modules/restapi/model/src/main/java/types/NicInterface.java A backend/manager/modules/restapi/model/src/main/java/types/NicStatus.java A backend/manager/modules/restapi/model/src/main/java/types/NumaTuneMode.java M backend/manager/modules/restapi/model/src/main/java/types/OpenStackNetworkProvider.java M backend/manager/modules/restapi/model/src/main/java/types/OpenstackVolumeAuthenticationKey.java A backend/manager/modules/restapi/model/src/main/java/types/OpenstackVolumeAuthenticationKeyUsageType.java M backend/manager/modules/restapi/model/src/main/java/types/OperatingSystem.java A backend/manager/modules/restapi/model/src/main/java/types/OsType.java M backend/manager/modules/restapi/model/src/main/java/types/Payload.java A backend/manager/modules/restapi/model/src/main/java/types/PayloadEncoding.java M backend/manager/modules/restapi/model/src/main/java/types/PmProxy.java A backend/manager/modules/restapi/model/src/main/java/types/PmProxyType.java A backend/manager/modules/restapi/model/src/main/java/types/PolicyUnitType.java A backend/manager/modules/restapi/model/src/main/java/types/PowerManagementStatus.java M backend/manager/modules/restapi/model/src/main/java/types/Qos.java A backend/manager/modules/restapi/model/src/main/java/types/QosType.java A backend/manager/modules/restapi/model/src/main/java/types/QuotaModeType.java M backend/manager/modules/restapi/model/src/main/java/types/ReportedDevice.java A backend/manager/modules/restapi/model/src/main/java/types/ReportedDeviceType.java A backend/manager/modules/restapi/model/src/main/java/types/ResolutionType.java M backend/manager/modules/restapi/model/src/main/java/types/RngDevice.java A backend/manager/modules/restapi/model/src/main/java/types/RngSource.java A backend/manager/modules/restapi/model/src/main/java/types/RoleType.java A backend/manager/modules/restapi/model/src/main/java/types/SELinuxMode.java M backend/manager/modules/restapi/model/src/main/java/types/SchedulingPolicyUnit.java A backend/manager/modules/restapi/model/src/main/java/types/ScsiGenericIO.java M backend/manager/modules/restapi/model/src/main/java/types/SeLinux.java M backend/manager/modules/restapi/model/src/main/java/types/SerialNumber.java A backend/manager/modules/restapi/model/src/main/java/types/SerialNumberPolicy.java M backend/manager/modules/restapi/model/src/main/java/types/Snapshot.java A backend/manager/modules/restapi/model/src/main/java/types/SnapshotStatus.java A backend/manager/modules/restapi/model/src/main/java/types/SnapshotType.java A backend/manager/modules/restapi/model/src/main/java/types/SpmState.java A backend/manager/modules/restapi/model/src/main/java/types/SsoMethod.java M backend/manager/modules/restapi/model/src/main/java/types/Step.java A backend/manager/modules/restapi/model/src/main/java/types/StepEnum.java M backend/manager/modules/restapi/model/src/main/java/types/StorageConnection.java M backend/manager/modules/restapi/model/src/main/java/types/StorageDomain.java A backend/manager/modules/restapi/model/src/main/java/types/StorageDomainStatus.java A backend/manager/modules/restapi/model/src/main/java/types/StorageDomainType.java A backend/manager/modules/restapi/model/src/main/java/types/StorageFormat.java A backend/manager/modules/restapi/model/src/main/java/types/StorageType.java A backend/manager/modules/restapi/model/src/main/java/types/TemplateStatus.java A backend/manager/modules/restapi/model/src/main/java/types/TransportType.java M backend/manager/modules/restapi/model/src/main/java/types/Usb.java A backend/manager/modules/restapi/model/src/main/java/types/UsbType.java M backend/manager/modules/restapi/model/src/main/java/types/Vm.java A backend/manager/modules/restapi/model/src/main/java/types/VmAffinity.java M backend/manager/modules/restapi/model/src/main/java/types/VmBase.java A backend/manager/modules/restapi/model/src/main/java/types/VmDeviceType.java M backend/manager/modules/restapi/model/src/main/java/types/VmPlacementPolicy.java M backend/manager/modules/restapi/model/src/main/java/types/VmPool.java A backend/manager/modules/restapi/model/src/main/java/types/VmPoolType.java A backend/manager/modules/restapi/model/src/main/java/types/VmStatus.java A backend/manager/modules/restapi/model/src/main/java/types/VmType.java M backend/manager/modules/restapi/model/src/main/java/types/VnicPassThrough.java A backend/manager/modules/restapi/model/src/main/java/types/VnicPassThroughMode.java M backend/manager/modules/restapi/model/src/main/java/types/Watchdog.java A backend/manager/modules/restapi/model/src/main/java/types/WatchdogAction.java A backend/manager/modules/restapi/model/src/main/java/types/WatchdogModel.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java 191 files changed, 1,935 insertions(+), 2,089 deletions(-) Approvals: Ori Liel: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1673f75793f6ba66e8b92eb7cb6eb2e1f9cc4740 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;