Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Add runtime log4j setup to engine-config ...................................................................... tools: Add runtime log4j setup to engine-config 1) Moves default log4j.xml for engine-config into tools.jar 2) By default logging is off 3) Adds --log-file which sets file to write logging messages into 4) Adds --log-level which sets logging level for logger specified with --log-file (it's set to INFO by default) 5) Adds --log4j-config which sets filename or URL with custom log4j.xml file to setup logging Change-Id: I328a018ef1b714c6a90d1b219dcd326a16bcab2d Bug-Url: https://bugzilla.redhat.com/1063901 Signed-off-by: Martin Perina <mperina(a)redhat.com&gt; --- M Makefile M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/OptionKey.java A backend/manager/tools/src/main/resources/engine-config/log4j.xml M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigTest.java M ovirt-engine.spec.in M packaging/bin/engine-config.sh D packaging/etc/engine-config/log4j.xml.in M packaging/man/man8/engine-config.8 12 files changed, 137 insertions(+), 76 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I328a018ef1b714c6a90d1b219dcd326a16bcab2d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server