Omer Frenkel has submitted this change and it was merged.
Change subject: core: Block changing sound device configuration for running vm
......................................................................
core: Block changing sound device configuration for running vm
This check is missing, users should not change properties of a running
vm, as this is not reflected in the vm and may cause confusion.
Change-Id: I923299830e1497306b7c5a2b25e9c3e523f20d29
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 21 insertions(+), 6 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit
http://gerrit.ovirt.org/17011
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I923299830e1497306b7c5a2b25e9c3e523f20d29
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server