Tal Nisan has submitted this change and it was merged.
Change subject: engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB
......................................................................
engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB
We have a lot of similar constants across the Engine. BYTES_TO_GB is
one of them. Generic org.ovirt.engine.core.common.utils.SizeConverter
introduces BYTES_IN_GB which can be used instead of
IrsBrokerCommand.BYTES_TO_GB.
Change-Id: I0a3cede172aebab1182dca0ceec901be8553e6ae
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java
4 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/21314
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a3cede172aebab1182dca0ceec901be8553e6ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server