Muli Salem has submitted this change and it was merged.
Change subject: engine: Network Command Validation
......................................................................
engine: Network Command Validation
This patch extracts repetitive code to the
NetworkCommon class, and cleans up canDoActions
in both AddNetwork and UpdateNetwork commands, to
use the Validation framework given by the
CommandBase.
Change-Id: I4bb5bafd2029b3a8729bcf78d359804c6f587ff7
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
3 files changed, 104 insertions(+), 61 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/10542
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bb5bafd2029b3a8729bcf78d359804c6f587ff7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>