Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: update firewall for all services ...................................................................... packaging: setup: update firewall for all services Update the firewall for websocket_proxy and postgresql not only during setup. Always ask whether to update the firewall and do not keep the answer in the postinstall answer file, to allow users to keep their manual changes on upgrades. Output manual configuration instructions only for supported firewall managers. Bug-Url: https://bugzilla.redhat.com/1024707 Bug-Url: https://bugzilla.redhat.com/1029020 Bug-Url: https://bugzilla.redhat.com/1023316 Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com&gt; Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com&gt; --- M packaging/setup/ovirt_engine_setup/constants.py A packaging/setup/ovirt_engine_setup/firewall_manager_base.py A packaging/setup/plugins/ovirt-engine-common/network/__init__.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager_firewalld.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager_human.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager_iptables.py A packaging/setup/plugins/ovirt-engine-common/network/process_firewalld_services.py M packaging/setup/plugins/ovirt-engine-remove/network/__init__.py A packaging/setup/plugins/ovirt-engine-remove/network/firewall_manager.py D packaging/setup/plugins/ovirt-engine-remove/network/firewalld.py M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/legacy/__init__.py D packaging/setup/plugins/ovirt-engine-setup/legacy/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 16 files changed, 954 insertions(+), 393 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server